FlxBitmapFont: Remove background of XNA fonts #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing bmd.threshold() with bgColor32 is necessary to prevent the background color from appearing between letters when a FlxBitmapText using this font is scaled by a non-integer value
|
Thanks! I bet this was only an issue with some ancient OpenFL version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a FlxBitmapText uses a font that was created using FlxBitmapFont.fromXNA(), and the zoom of the current FlxCamera is a non-integer value, the background color that separates characters in the font's source image can sometimes appear between characters in the FlxBitmapText (see example here.) There is already code in place to remove this background color from the font, but it's currently restricted to the Flash target only, apparently due to crashes on other platforms. I removed the conditional check for Flash and tested FlxBitmapFont.fromXNA() on HTML5, Linux, Neko, and Windows; none of them crashed, and as desired, the background color no longer appears between the characters.